Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaced target from main tag to div with id "root" for semantic HTML #130

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

SvMak
Copy link
Contributor

@SvMak SvMak commented Jan 9, 2024

Checklist

Thank you for so great plugin!

The <main> tag specifies the main content of a document.
The content inside the <main> element should be unique to the document. It should not contain any content that is repeated across documents such as sidebars, navigation links, copyright information, site logos, and search forms.

In my case I need use semantic markup for predefined @fastify/react and I make small fixes.

Additional: upgraded vitest veresion to ^1.0.0 for examples packages.

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for agitated-mahavira-26f8f9 ready!

Name Link
🔨 Latest commit 5b025dd
🔍 Latest deploy log https://app.netlify.com/sites/agitated-mahavira-26f8f9/deploys/659d8d8d33a75f00090bfeb6
😎 Deploy Preview https://deploy-preview-130--agitated-mahavira-26f8f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@galvez galvez changed the title Replaced target from main tag to div with id "root" fix: replaced target from main tag to div with id "root" for semantic HTML Jan 15, 2024
@galvez galvez merged commit 6b94e1d into fastify:dev Jan 15, 2024
4 checks passed
@galvez galvez mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants