Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exlude node 14 and 16 for macos-latest #163

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

nickfla1
Copy link
Contributor

Addresses issues with CI found in #162 (comment)

Excludes MacOS CI from running on Node versions 14 and 16.

Checklist

@nickfla1 nickfla1 force-pushed the exclude-node-versions branch from fefef80 to a7e379a Compare August 13, 2024 09:02
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Node: macos-latest is using an M1 ARM cpu but Node 14 and 16 were never compiled for ARM cpu.

@Uzlopak Uzlopak merged commit cd91c0d into fastify:v4.x Aug 13, 2024
87 checks passed
@nickfla1 nickfla1 deleted the exclude-node-versions branch August 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants