-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow serving static assets from baseDir
#108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few issues with doc changes.
Will flesh this out once I'm finished at work.
@Fdawgs ptal |
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Any idea on when this can be merged? |
I'm concerned this is a breaking change in behaviour and needs to be highlighted as such when it gets published - but would like a second opinion. Prior to this change, if you set With this change, if you set So a working configuration prior to this PR will no longer work when this PR is applied. |
Resolves #65
This PR documents how to serve static swagger-ui files from a custom directory and fixes serving static assets when the
baseDir
option is set.Checklist
npm run test
andnpm run benchmark
and the Code of conduct