-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for typescript http2/https warning #115
Conversation
Hm, change of index.d.ts can break somehow test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you cover this in the types tests?
@mcollina changed types/index.ts in fastify-cookies style, if it's what you mean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you good work 👍
@Ethan-Arrowood is this a patch for TS's users? |
Yes this is a patch fix 👍 |
Fix for #114
I'm not an expert in typescript and declaration files, but i was able to adapt fastify-static declaration file in style of fastify-cookie declaration file (that gives no typescript warnings).
Now it should compile without problems for http2 and htpps too.
Checked on my own server with http, http2 and https settings for server.