-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): replace standard with neostandard #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdawgs
changed the title
chore: add eslint.config.js
build(deps-dev): replace standard with neostandard
Dec 8, 2024
Fdawgs
force-pushed
the
build/standard
branch
from
December 15, 2024 20:01
52afc5c
to
b61dc34
Compare
@arthurfiorette the line failing linting was added in #148 by yourself. |
Sure! let me take a look at it |
Fdawgs
commented
Dec 16, 2024
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
This seems to be a parsing error from eslint, that's a valid alternative and also the most preferred one. Its safe to rename. |
arthurfiorette
suggested changes
Dec 16, 2024
Co-authored-by: Arthur Fiorette <47537704+arthurfiorette@users.noreply.github.com> Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Co-authored-by: Arthur Fiorette <47537704+arthurfiorette@users.noreply.github.com> Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fastify/fastify-cors#340. This is a batch PR, so may have some issues. Please review changes.