Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable custom errors #16

Merged
merged 3 commits into from
Dec 19, 2018
Merged

Add option to disable custom errors #16

merged 3 commits into from
Dec 19, 2018

Conversation

cemremengu
Copy link
Contributor

@cemremengu cemremengu commented Dec 19, 2018 •
edited
Loading

Closes #16

I named the option as redactErrors but I am open to better naming suggestions. Maybe hideErrors ? Let me know.

@mcollina
Copy link
Member

I would call this errorHandler.

redactErrors conflicts a bit with the naming pino log redaction feature.

mcollina
mcollina approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemremengu cemremengu requested a review from delvedor December 19, 2018 09:24
delvedor
delvedor approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemremengu cemremengu merged commit 9e3f11d into master Dec 19, 2018
@cemremengu cemremengu deleted the disable-custom-err branch December 19, 2018 11:30
@cemremengu cemremengu mentioned this pull request Dec 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemremengu @mcollina @delvedor