Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't amount to much, but I'm consistently seeing faster initialization results with a for loop instead of forEach. I tested the difference very simply by wrapping the whole plugin with
console.time()
and running the tests. With the for loop, the startup almost always takes less then 0.01ms, which otherwise does not happen on my machineThis PR also fixes a test,
makes linting part of the test suite, adds thelint:fix
script as well as@fastify/pre-commit
OLD
NEW
Checklist
npm run test
andnpm run benchmark
and the Code of conduct