Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export originCallback and originFunction #64

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Export originCallback and originFunction #64

merged 1 commit into from
Jul 19, 2020

Conversation

ghostd
Copy link
Contributor

@ghostd ghostd commented May 2, 2020

Fixes #62 #63

mcollina
mcollina approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SerayaEryn
SerayaEryn approved these changes Jun 14, 2020
View reviewed changes
Copy link
Contributor

@SerayaEryn SerayaEryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm
Copy link
Member

Eomm commented Jul 17, 2020

Would @ghostd mind to update the PR?

I think we are late for the merge and release, feel free to ping me for these tasks 👍

@ghostd
Copy link
Contributor Author

ghostd commented Jul 18, 2020

I rebased the PR and updated the tests to check the OriginFunction type is exported.

mcollina
mcollina approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 29000a9 into fastify:master Jul 19, 2020
@ghostd ghostd deleted the fix-types branch January 14, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@SerayaEryn SerayaEryn SerayaEryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More types should be exported
4 participants
@ghostd @Eomm @mcollina @SerayaEryn