-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: better support typescript #372
Conversation
Double checked the test is failed even in current |
Can you fix it? |
Tests are fixed on master |
The changes here is It may land in |
Then can you make so? ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@climba03003 Thank you for this! I know this was already in merged in May, but still I wanted to thank you. |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct