Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): consider preParsing hook safe #251

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jan 29, 2025

This PR updates the security considerations to consider the preParsing hook safe for auth functionality. The body is not parsed at this stage, so DoS attacks are negated just like they would be with an onRequest hook.

Inspired by discussion in fastify/fastify-bearer-auth#207

Checklist

Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
@Fdawgs Fdawgs merged commit ba755cc into master Jan 30, 2025
2 checks passed
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch January 30, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants