Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composite auth OR #224

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

yakovenkodenis
Copy link
Contributor

This fixes issue described in #223

Checklist

@isnifer
Copy link

isnifer commented Feb 19, 2024

I completed to create repro for #223, I will check this version locally immediately

@isnifer
Copy link

isnifer commented Feb 19, 2024

@yakovenkodenis thank you for your time, I can confirm that your fix is working.
image

On this screenshot I made a request and passed it through preHandler decorated via @fastify/auth.
On the left side 4.4.0, in the middle 4.5.0, on the right side fixed version from Denis.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

@Eomm could you take a look as well?

@Eomm Eomm self-requested a review February 22, 2024 12:57
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landing!

@Eomm Eomm merged commit 0305a08 into fastify:master Feb 26, 2024
19 checks passed
@yakovenkodenis yakovenkodenis deleted the bug/composite-auth branch February 27, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants