Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor busboy constructor - add esm #61

Merged
merged 17 commits into from
Dec 4, 2021
Merged

refactor busboy constructor - add esm #61

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f02dd0b
refactor busboy constructor
Uzlopak Dec 3, 2021
0f0f5d1
add documentation for autoDestroy
Uzlopak Dec 3, 2021
2475e4a
avoid for-loop
Uzlopak Dec 3, 2021
6de03dc
add unit test for invalid highwatermark
Uzlopak Dec 3, 2021
e1b002b
fix failing test
Uzlopak Dec 3, 2021
1b0e88d
rename method
Uzlopak Dec 3, 2021
4a8f5a5
add information about default false of autoDestroy
Uzlopak Dec 3, 2021
48cb5e5
better wording
Uzlopak Dec 3, 2021
7a659eb
add infamous esm cjs triplet
Uzlopak Dec 4, 2021
c0c17c9
add information to changelog, that busboy is importable as esm.
Uzlopak Dec 4, 2021
7e6dd6b
Merge branch 'fastify:master' into refactor-busboy-constructor
Uzlopak Dec 4, 2021
39281e5
update documentation
Uzlopak Dec 4, 2021
c5fd1a6
Merge branch 'master' into refactor-busboy-constructor
Uzlopak Dec 4, 2021
a16181a
test for esm
Uzlopak Dec 4, 2021
688cb2e
Merge branch 'refactor-busboy-constructor' of https://github.com/Uzlo…
Uzlopak Dec 4, 2021
81666f4
use expectType
Uzlopak Dec 4, 2021
f29d836
export Busboy as named export
Uzlopak Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/types/main.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import BusboyDefault, { BusboyConstructor, BusboyConfig, BusboyHeaders, Busboy, BusboyEvents, BusboyFileStream } from '../..';
import {expectError, expectType} from "tsd";
import BusboyESM from "../..";

// test type exports
type Constructor = BusboyConstructor;
Expand All @@ -8,6 +9,8 @@ type Headers = BusboyHeaders;
type Events = BusboyEvents;
type BB = Busboy;

new BusboyESM({ headers: { 'content-type': 'foo' } }); // $ExpectType Busboy
Uzlopak marked this conversation as resolved.
Show resolved Hide resolved

expectError(new BusboyDefault({}));
const busboy = BusboyDefault({ headers: { 'content-type': 'foo' } }); // $ExpectType Busboy
new BusboyDefault({ headers: { 'content-type': 'foo' } }); // $ExpectType Busboy
Expand Down