New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce standard #45

Merged

Uzlopak merged 5 commits into fastify:master from Uzlopak:enforce-standard

Nov 30, 2021

Contributor

Uzlopak commented Nov 30, 2021 •

edited

Loading

This PR consists of three commits:

activate standard in project configuration
run the standard fixer
add button to Readme.md

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

Uzlopak added 3 commits

November 30, 2021 16:06


          activate standard in configuration

aabe6b4


          enforced standard

8e34569


          add button for standardjs

5c5ea6d

Uzlopak requested a review from kibertoad

November 30, 2021 15:09

kibertoad reviewed

View reviewed changes

deps/dicer/lib/Dicer.js

               }
-              inherits(Dicer, WritableStream);
+              inherits(Dicer, WritableStream)

Member

kibertoad Nov 30, 2021

we should try rewriting to classes and measure performance

Contributor Author

Uzlopak Nov 30, 2021

yeah, maybe for the next release :)

kibertoad reviewed

View reviewed changes

deps/dicer/lib/HeaderParser.js Outdated Show resolved Hide resolved

kibertoad reviewed

View reviewed changes

deps/streamsearch/sbmh.js Outdated Show resolved Hide resolved

kibertoad reviewed

View reviewed changes

deps/streamsearch/sbmh.js Outdated Show resolved Hide resolved

kibertoad reviewed

View reviewed changes

lib/main.js Outdated Show resolved Hide resolved

kibertoad reviewed

View reviewed changes

lib/types/urlencoded.js Outdated Show resolved Hide resolved


          ignore no-var if it is used in for loops

b19df55

Contributor Author

Uzlopak commented Nov 30, 2021

I only kept the let variables in the tests, as they are not performance critical.


          fix buttons

993da0d

kibertoad approved these changes

View reviewed changes

Uzlopak merged commit fffacdf into fastify:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet