fix empty part bug #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruur Maybe you would like to participate in discussion? |
|
@kibertoad I think this is a dicer bug, not busboy, which can only be corrected in dicer. |
|
@ruur We inlined dicer into fastify-busboy, so we can try fixing it now. |
|
created a new PR #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not mergable. It adds a unit test to test if the bug still exists.
If I apply the patch from
mscdex/dicer#23
then it still throws an error. I would have actually expected gracefully handling part and skipping it.
We have to discuss, what the best approach is to solve this issue.
Checklist
npm run testandnpm run benchmarkand the Code of conduct