Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): fix repository url #143

Merged
merged 1 commit into from
Jan 29, 2024
Merged

chore(package): fix repository url #143

merged 1 commit into from
Jan 29, 2024

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jan 25, 2024

See fastify/aws-lambda-fastify#195

Checklist

Signed-off-by: Frazer Smith <frazer.dev@outlook.com>
@@ -55,7 +55,7 @@
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/fastify/busboy.git"
"url": "git+https://github.com/fastify/busboy.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this syntax come from? I don't see it in https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibertoad 🤷 comes from running npm pkg fix using npm 10.4.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm gonna npm. probably they changed something and didn't update the docs accordingly

@Fdawgs Fdawgs requested review from kibertoad and a team January 25, 2024 16:19
@gurgunday gurgunday merged commit cddb64d into master Jan 29, 2024
22 checks passed
@gurgunday gurgunday deleted the Fdawgs-patch-1 branch January 29, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants