Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add _trackPluginLoading method and fix root name #232

Merged
merged 4 commits into from
Aug 15, 2023
Merged

chore: add _trackPluginLoading method and fix root name #232

merged 4 commits into from
Aug 15, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 14, 2023

Simplify the code, add a _trackPluginLoading and also fix the root name. It will now show root and not "bound root". Which is nicer imho.

Checklist

metcoder95
metcoder95 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's some conflicts with master, rest LGTM

@Uzlopak Uzlopak merged commit 16f0f5f into master Aug 15, 2023
@Uzlopak Uzlopak deleted the trackLPluginLoading branch August 15, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metcoder95 metcoder95 metcoder95 approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@Eomm Eomm Awaiting requested review from Eomm

@climba03003 climba03003 Awaiting requested review from climba03003

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @metcoder95