Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calling avvio with new #230

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: calling avvio with new #230

merged 1 commit into from
Aug 14, 2023

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 14, 2023

This PR fixes an issue, where calling avvio with new would result in a broken result, as enriching the instance with the avvio attributes would only happen if we didnt call it with new.

Checklist

@Uzlopak Uzlopak requested review from mcollina and Eomm August 14, 2023 11:33
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good work!

@Uzlopak Uzlopak merged commit 9fa77f0 into master Aug 14, 2023
@Uzlopak Uzlopak deleted the avvio-new branch August 14, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants