Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump click minimum version to 8.0.0 #463

Closed
wants to merge 2 commits into from

Conversation

texasfight
Copy link

Click major version 7 does not properly work because of the following error: AttributeError: module 'click.utils' has no attribute '_expand_args'

The _expand_args method was added in click major version 8.

Fixes issue: #427

Click major version 7 does not properly work because of the following error:
`AttributeError: module 'click.utils' has no attribute '_expand_args'`

The `_expand_args` method was added in click major version 8.
@texasfight
Copy link
Author

@tiangolo Currently typer.core:190, which is causing issues, is being ignored by a pragma: no cover. Furthermore, the tests never fail since all of the CI/CD testing pipelines are using Ubuntu and not Windows.

As an alternative to bumping the required version, we could just implement the logic in click.utils._expand_args ourselves since it just uses the glob and os builtin libraries.

If we're removing support for click-7, we would want to remove the extra actions that are being performed to ensure backwards compat.
@RileyMShea
Copy link

It seems for the current version of typer(0.9.0), only click=8.0.4 is working completely.

Click < 7.x and click >8.1.x both have their own problems with type atm.

Recommend further narrowing click range down to: "click >= 8.0.0, <8.1.0"

@LeXofLeviafan
Copy link

It seems for the current version of typer(0.9.0), only click=8.0.4 is working completely.

Click < 7.x and click >8.1.x both have their own problems with type atm.

Recommend further narrowing click range down to: "click >= 8.0.0, <8.1.0"

Click 8.1 appears to be supported since Typer 4.1.0 release (according to release notes). Have you checked if there's actually any issue with Click 8.1?

@svlandeg svlandeg added feature New feature, enhancement or request click Related to Click functionality dependencies Pull requests that update a dependency file p3 bug Something isn't working p2 and removed investigate feature New feature, enhancement or request p3 labels Mar 8, 2024
@svlandeg
Copy link
Member

Hi! Apologies for the late follow-up. Tiangolo is working on a PR that includes the edits from this one, so I'll go ahead and close this one in favour of #760. Thanks for the contribution & discussion though!

@svlandeg svlandeg closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working click Related to Click functionality dependencies Pull requests that update a dependency file p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants