Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rephrase the documentation to avoid the word "compromise" and use direct language #650

Closed
wants to merge 3 commits into from
Closed

Rephrase the documentation to avoid the word "compromise" and use direct language #650

wants to merge 3 commits into from

Conversation

lbenitez000
Copy link
Contributor

Changed a few words in the documentation to

  1. Use "Have a Contract" instead of "Compromise" as it may be interpreted as "trade-off"
  2. Use "must" and "will" instead of "would" to show that it's a commitment

@tiangolo tiangolo added the docs Improvements or additions to documentation label Oct 22, 2023
@github-actions
Copy link

📝 Docs preview for commit 1d08683 at: https://65bdb805.sqlmodel.pages.dev

@tiangolo
Copy link
Member

Thank you @lbenitez000! 🚀

I got confused with this PR and thought I couldn't push to your branch to update, but I was using the wrong branch. 🤦

I ended up adding a new PR including your commits here #674

And now I realize that I was looking at the wrong branch.

Anyway, thank you for your help! ☕

@tiangolo tiangolo closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbenitez000 @tiangolo