-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 update: upgrade python and depends #517
Conversation
- Min python version 3.8.1 - Upgrade all dev dependencies - Fix main ForwardRef - Fix test tutorial with fastapi
…rziale/sqlmodel into upgrade_python_and_depends
📝 Docs preview for commit 23678cb at: https://639e838dc1082f1db1d1c58b--sqlmodel.netlify.app |
📝 Docs preview for commit 1274169 at: https://639e8540ecf1fd1e689b4021--sqlmodel.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should update workflows to install poetry instead of doing the workaround for installing a specific version of poetry and poetry-core for 3.6.
publish.yml was not updated 3.7 -> 3.8.
Dockerfiles were not updated 3.7 -> 3.8.
Check for != '3.6.15' in test.yml not removed.
TODO regarding python 3.6 removal in lint.sh should be fixed.
There are still dependencies for python 3.6 in pyproject.toml, async_generator and async-exit-stack.
expression.py.jinja2 should be updated to remove the version check.
- poetry version 1.3.1 - drop install manual poetry-core
📝 Docs preview for commit 919e441 at: https://63a2147a3b696d12029fe783--sqlmodel.netlify.app |
919e441
to
1ba339f
Compare
📝 Docs preview for commit 1ba339f at: https://63a216602eefb815355aa078--sqlmodel.netlify.app |
📝 Docs preview for commit 699b646 at: https://63a216d2ea76c21aafd103bb--sqlmodel.netlify.app |
📝 Docs preview for commit dcf6140 at: https://63a219a358d76a1571b20005--sqlmodel.netlify.app |
dcf6140
to
699b646
Compare
📝 Docs preview for commit 699b646 at: https://63a21b33ba9b2c17eecb2f28--sqlmodel.netlify.app |
- set minim python version 3.8
📝 Docs preview for commit 4f7d980 at: https://63a21ba758d76a1815b1ff66--sqlmodel.netlify.app |
All changes are resolved. Thanks for the observations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the nice changes! I found a few more but they are minor
tests/test_tutorial/test_fastapi/test_multiple_models/test_tutorial001.py
Outdated
Show resolved
Hide resolved
Co-authored-by: mcoms <mastercoms@tuta.io>
Co-authored-by: mcoms <mastercoms@tuta.io>
📝 Docs preview for commit 3167c41 at: https://63a320a3a811af2309bc71cf--sqlmodel.netlify.app |
📝 Docs preview for commit 37186b0 at: https://63a39c69a811af1168bc711f--sqlmodel.netlify.app |
184618b
to
37186b0
Compare
📝 Docs preview for commit 37186b0 at: https://63a3a6c2e3fb8112e0bb35d5--sqlmodel.netlify.app |
- drop poetry-version-plugin - now set version in poetry
📝 Docs preview for commit 1b77fde at: https://63a3a786fb6de8188009c8d4--sqlmodel.netlify.app |
📝 Docs preview for commit 9613c5a at: https://63a3a9b21e71fa18d1c24361--sqlmodel.netlify.app |
📝 Docs preview for commit d2a9cc4 at: https://63e24058f64ab95d6df61415--sqlmodel.netlify.app |
Thanks for the interest! This PR covers many things, so it's better to split it into separate PRs. Some of these things were already done in other PRs, others I would not do yet, for example, I won't drop support for Python 3.7 just yet. And the upgrade for dependencies would also be better in isolated PRs. Because of that, I'm gonna close this one. But anything else that you think should go, it would be better in a new PR, one for each specific change. Thanks for the effort! ☕ |
Changes:
Now with mkdocs 1.4.2 and mkdocs-material 8.5.11 the docs site is created ok without some bugs.