Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Raise SQLAlchemy version requirement to at least 1.4.29 (related to #434) #439

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

daniil-berg
Copy link
Contributor

As @JoshGooch pointed out in #434, SQLAlchemy Session.get only supports the execution_options since version 1.4.29. Support for that parameter was added to SQLModel via #302, but the version requirement is still at >=1.4.17.

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (6d170c4) 97.76%.
Report is 62 commits behind head on main.

❗ Current head 6d170c4 differs from pull request most recent head b297bba. Consider uploading reports for the commit b297bba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   98.49%   97.76%   -0.74%     
==========================================
  Files         185      187       +2     
  Lines        5856     6268     +412     
==========================================
+ Hits         5768     6128     +360     
- Misses         88      140      +52     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

📝 Docs preview for commit 6d170c4 at: https://631731951693a955e3059257--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit c58fafb at: https://639ce0c2f6c06900ababea4c--sqlmodel.netlify.app

@antont
Copy link

antont commented Jun 2, 2023

we've been happily using 1.4.41 so +1 from here.

@tiangolo tiangolo added the bug Something isn't working label Oct 22, 2023
@tiangolo tiangolo changed the title ⬆ Raise SQLAlchemy version requirement to at least 1.4.29 (fixes #434) ⬆ Raise SQLAlchemy version requirement to at least 1.4.29 (related to #434) Oct 23, 2023
@github-actions
Copy link

📝 Docs preview for commit b297bba at: https://450cd5cd.sqlmodel.pages.dev

@tiangolo tiangolo merged commit 9511c46 into fastapi:main Oct 23, 2023
9 checks passed
@tiangolo
Copy link
Member

Thank you! This will be available in the next version, 0.0.9. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants