-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
By default columns should not have indexes #11
Conversation
@tiangolo Are there any plans to merge this? I'd love to start using SQLModel in my projects, but this is a blocker. |
@tiangolo ping... |
@tiangolo any updates on this issue? Seems like this PR is fixing a typo which is creating indexes on all columns. It'd nice to have this merged so I don't have to manually edit all my Alembic migration files and remove those extra indexes. |
Fixes #152 |
@tiangolo update on merge? |
Any ETA on when this might be merged and released on PyPI? Seems like a pretty straight-forward and simple change. Are there concerns about it breaking something? |
Still no progress? :( |
Thank you @CaselIT! 🚀 And thanks everyone for the discussion. I didn't want to merge this without documenting it, adding tests, updating the examples and docs, etc. I did all that in #205, the new docs explaining indexes are here: https://sqlmodel.tiangolo.com/tutorial/indexes/ Indexes are now opt-in and not created by default. You can read more about it all in that PR. It is now released as part of SQLModel Given that, I'll close this PR now. ☕ |
Fixes #9