Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default columns should not have indexes #11

Closed
wants to merge 1 commit into from

Conversation

CaselIT
Copy link

@CaselIT CaselIT commented Aug 25, 2021

Fixes #9

@uolot
Copy link

uolot commented Sep 21, 2021

@tiangolo Are there any plans to merge this? I'd love to start using SQLModel in my projects, but this is a blocker.

@hidaris
Copy link

hidaris commented Oct 9, 2021

@tiangolo ping...

@perseghini
Copy link

@tiangolo any updates on this issue? Seems like this PR is fixing a typo which is creating indexes on all columns. It'd nice to have this merged so I don't have to manually edit all my Alembic migration files and remove those extra indexes.

RobertRosca added a commit to RobertRosca/sqlmodel that referenced this pull request Nov 2, 2021
@rabinadk1
Copy link
Contributor

Fixes #152

@mkarbo
Copy link

mkarbo commented Dec 6, 2021

@tiangolo update on merge?

@FFX01
Copy link

FFX01 commented Dec 6, 2021

Any ETA on when this might be merged and released on PyPI? Seems like a pretty straight-forward and simple change. Are there concerns about it breaking something?

@heyaco
Copy link

heyaco commented Dec 22, 2021

Still no progress? :(

@tiangolo
Copy link
Member

Thank you @CaselIT! 🚀

And thanks everyone for the discussion.

I didn't want to merge this without documenting it, adding tests, updating the examples and docs, etc.

I did all that in #205, the new docs explaining indexes are here: https://sqlmodel.tiangolo.com/tutorial/indexes/

Indexes are now opt-in and not created by default. You can read more about it all in that PR.

It is now released as part of SQLModel 0.0.6. 🎉

Given that, I'll close this PR now. ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alembic Migration when going from SQLAlchemy declarative_base to SQLModel adding indexes