Update fmt version #204
Closed
Update fmt version #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #202, updates
fmtto latest version so we do not have to pin to 8.1.There were some changes between fmt 8.1 and 10.1 around support for
std::ostreamformatting -- it is now required to explicitly specialize a template to register an ostream formatter. This prevents possible ODR violation.AFAIK the C++20-standardized std::format doesn't support ostream formatting at all. Long-term we may want to consider an approach that falls back to
fmtonly when standard library support is not present -- this would require moving away from relying on ostream formatting altogether.