Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix handling of error logging in API request #2526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xlora
Copy link

@0xlora 0xlora commented Feb 11, 2025

Why is this change needed?

I've fixed the issue where the response variable might not be available in the catch block. Instead of trying to log the response when an error occurs, we now log the actual error (e).
This ensures better error tracking even when the request fails.

Merge Checklist


PR-Codex overview

This PR focuses on improving error handling in the code by changing the logged output when an error occurs.

Detailed summary

  • In the catch block, the logged output was changed from console.log(response); to console.log(e);, ensuring that the actual error e is logged instead of the response.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: 2a972d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 6:36pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant