fix: Add missing envars and increase default balance in docker-compose.yml
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horsefacts
approved these changes
Nov 6, 2023
|
These image build tests have been flaky lately. I haven't had a chance to fix them, but I think it's just a race condition in the CI script. Re-building usually fixes it. |
…se.yml` In order to reference this Docker Compose configuration in another `docker-compose.yml` and have it be easier to inject environment variables, we need to declare the envars we're expecting. Also while here, increase the amount of ETH allocated to make local testing easier.
sds
force-pushed
the
sds/fix-docker-compose
branch
from
a70a459
to
c948e29
Compare
|
Coverage after merging sds/fix-docker-compose into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to reference this Docker Compose configuration in another
docker-compose.ymland have it be easier to inject environment variables, we need to declare the envars we're expecting.Change Summary
Also while here, increase the amount of ETH allocated to make local testing easier.
Merge Checklist
PR-Codex overview
Focus of this PR:
Update the command in the CI workflow and the balance in the docker-compose file.
Detailed summary: