Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(NameRegistry): registrations last for one year #125

Merged
merged 16 commits into from
Sep 15, 2022

Conversation

varunsrin
Copy link
Member

@varunsrin varunsrin commented Sep 14, 2022

Registering an fname now registers it for 365 days instead of registering it until the end of the calendar year. The renewal period is now 30 days, instead of 31 days. See this discussion for the rationale behind the changes.

The failing CI is due to a false positive code coverage check, which can be ignored. No uncovered lines of code were added by this PR but % coverage has dropped to due to removal of code and tests.

Notably, this change also made our contract a lot leaner:

  • Contract size is now 1.08 kb smaller
  • register is 8433 gas cheaper
  • bid is 6907 gas cheaper
  • trustedRegister is 717 gas cheaper
  • renew is 717 gas cheaper

@varunsrin varunsrin force-pushed the varunsrin/year-refactor branch from 20d7be3 to 8a844d6 Compare September 14, 2022 02:20
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 85.61% // Head: 84.61% // Decreases project coverage by -0.99% ⚠️

Coverage data is based on head (875f95a) compared to base (1c6bfac).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   85.61%   84.61%   -1.00%     
==========================================
  Files           8        8              
  Lines         285      260      -25     
  Branches       77       74       -3     
==========================================
- Hits          244      220      -24     
+ Misses         39       38       -1     
  Partials        2        2              
Impacted Files Coverage Δ
test/NameRegistryUpgrade.t.sol 77.77% <ø> (-11.70%) ⬇️
src/NameRegistry.sol 91.02% <100.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@varunsrin varunsrin merged commit 299fe67 into main Sep 15, 2022
@varunsrin varunsrin deleted the varunsrin/year-refactor branch September 15, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant