-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(NameRegistry): registrations last for one year #125
Conversation
20d7be3
to
8a844d6
Compare
Codecov ReportBase: 85.61% // Head: 84.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 85.61% 84.61% -1.00%
==========================================
Files 8 8
Lines 285 260 -25
Branches 77 74 -3
==========================================
- Hits 244 220 -24
+ Misses 39 38 -1
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Registering an fname now registers it for 365 days instead of registering it until the end of the calendar year. The renewal period is now 30 days, instead of 31 days. See this discussion for the rationale behind the changes.
The failing CI is due to a false positive code coverage check, which can be ignored. No uncovered lines of code were added by this PR but % coverage has dropped to due to removal of code and tests.
Notably, this change also made our contract a lot leaner:
register
is 8433 gas cheaperbid
is 6907 gas cheapertrustedRegister
is 717 gas cheaperrenew
is 717 gas cheaper