TSM: Log with SwapLogging trait #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the SwapLogging trait to the service.rs file. Implement the log prefix string as a combination of optional attributes.
h4sh3d
requested changes
Dec 30, 2022
| match self { | ||
| TradeStateMachine::StartTaker => { | ||
| attempt_transition_to_taker_connect_or_take_deal(event, runtime) | ||
| attempt_transition_to_taker_connect_or_take_deal(event, runtime, log_helper) |
There was a problem hiding this comment.
I don't see how to improve this while keeping the fns as is. But I'm fine going that direction...
h4sh3d
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the SwapLogging trait to the service.rs file. Implement the log prefix string as a combination of optional attributes.
The approach here is not exactly ideal to say the least. Any suggestions to improve it are most welcome.