Swapd: state refactors #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we add other SSM states, these won't hit the catchall
Lederstrumpf
force-pushed
the
swap_state_refactors
branch
from
ed33918 to
18d5ed7
Compare
TheCharlatan
requested changes
Dec 15, 2022
Co-authored-by: Reproducibility Matters <seb.kung@gmail.com>
Co-authored-by: TheCharlatan <seb.kung@gmail.com>
Lederstrumpf
force-pushed
the
swap_state_refactors
branch
from
5247cca to
ddb110c
Compare
Co-authored-by: TheCharlatan <seb.kung@gmail.com>
Lederstrumpf
force-pushed
the
swap_state_refactors
branch
from
93be0f3 to
7c275ef
Compare
TheCharlatan
approved these changes
Dec 15, 2022
h4sh3d
reviewed
Dec 15, 2022
Co-authored-by: h4sh3d <h4sh3d@protonmail.com>
h4sh3d
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of small independent refactors segregated by commits not tracked by open issues.
The commit 0938754 (couple swap role and wallet role when initiating maker) I'm unsure about, but would like to discuss stronger coupling of swap roles and wallet roles in handling.