Grpc: Support list offers endpoint #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the grpc endpoint to make use of the list offers and their status selector.
TheCharlatan
force-pushed
the
grpcListOffers
branch
from
f215ddf to
2896409
Compare
h4sh3d
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
tACK with the GUI
I left this comment for another PR later:
In general we should try to return more data with the gRPC service, e.g. here returning the status (if easily possible) would allow the UI to build easier contextual actions such as remove the revoke button on passed offers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the grpc endpoint to make use of the list offers and their status selector.