Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Use refund address for sweeping bitcoin through walletd #744

Merged

Conversation

TheCharlatan
Copy link
Member

This allows us to circumvent any dangers incurred from getting the btc addresses.

@TheCharlatan TheCharlatan linked an issue Nov 1, 2022 that may be closed by this pull request
@TheCharlatan TheCharlatan changed the title Bugfix: Use refund address for sweeping bitcoin in the wallet Bugfix: Use refund address for sweeping bitcoin through walletd Nov 1, 2022
@TheCharlatan TheCharlatan added the reliability Feature increasing the reliability of the service label Nov 1, 2022
Copy link
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@h4sh3d h4sh3d merged commit 59a8588 into farcaster-project:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reliability Feature increasing the reliability of the service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

walletd shouldn't sweep if swap aborted before taker commits
2 participants