-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: reunite reveal messages #743
Merged
TheCharlatan
merged 11 commits into
farcaster-project:main
from
h4sh3d:refactor/reunite-reveal-messages
Nov 28, 2022
Merged
Refactor: reunite reveal messages #743
TheCharlatan
merged 11 commits into
farcaster-project:main
from
h4sh3d:refactor/reunite-reveal-messages
Nov 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4sh3d
added
the
farcaster.dev testing
Currently apply (or to be applied) on farcaster.dev backend
label
Oct 19, 2022
h4sh3d
changed the title
Refactor/reunite reveal messages
Refactor: reunite reveal messages
Oct 19, 2022
h4sh3d
force-pushed
the
refactor/reunite-reveal-messages
branch
2 times, most recently
from
November 7, 2022 16:02
041444e
to
6881cc7
Compare
h4sh3d
force-pushed
the
refactor/reunite-reveal-messages
branch
from
November 15, 2022 10:16
6881cc7
to
38bdafd
Compare
This triggers
in the |
h4sh3d
force-pushed
the
refactor/reunite-reveal-messages
branch
from
November 28, 2022 11:07
38bdafd
to
f92024b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #742
This PR reunite the
Reveal::Param
andReveal::Proof
over one uniqueReveal
message.The feature is build on
Reveal2
type and all oldReveal
code has been commented only, when tested I'll add a commit to remove the comments and clean up the new code.