Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: reunite reveal messages #743

Merged

Conversation

h4sh3d
Copy link
Member

@h4sh3d h4sh3d commented Oct 19, 2022

Based on #742

This PR reunite the Reveal::Param and Reveal::Proof over one unique Reveal message.

The feature is build on Reveal2 type and all old Reveal code has been commented only, when tested I'll add a commit to remove the comments and clean up the new code.

@h4sh3d h4sh3d added the farcaster.dev testing Currently apply (or to be applied) on farcaster.dev backend label Oct 19, 2022
@h4sh3d h4sh3d changed the title Refactor/reunite reveal messages Refactor: reunite reveal messages Oct 19, 2022
@h4sh3d h4sh3d force-pushed the refactor/reunite-reveal-messages branch 2 times, most recently from 041444e to 6881cc7 Compare November 7, 2022 16:02
@h4sh3d h4sh3d force-pushed the refactor/reunite-reveal-messages branch from 6881cc7 to 38bdafd Compare November 15, 2022 10:16
@TheCharlatan
Copy link
Member

This triggers

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/swapd/runtime.rs:719:73`

in the swap_bob_maker_user_abort_sweep_btc test.

@h4sh3d h4sh3d force-pushed the refactor/reunite-reveal-messages branch from 38bdafd to f92024b Compare November 28, 2022 11:07
@h4sh3d
Copy link
Member Author

h4sh3d commented Nov 28, 2022

This triggers

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/swapd/runtime.rs:719:73`

in the swap_bob_maker_user_abort_sweep_btc test.

Fixed in a9d3e97

EDIT: full fix with 786ace2

@h4sh3d h4sh3d marked this pull request as ready for review November 28, 2022 12:45
@TheCharlatan TheCharlatan merged commit 4e171c6 into farcaster-project:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
farcaster.dev testing Currently apply (or to be applied) on farcaster.dev backend refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants