Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log as info level p2p msg sent and received per swap #738

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

h4sh3d
Copy link
Member

@h4sh3d h4sh3d commented Oct 12, 2022

Log outgoing and incoming p2p protocol message in a friendly manner with the corresponding swap id. Next step is to add them in the progress stack too, but I let it for another PR that improve the overall progress feature.

@h4sh3d h4sh3d added the farcaster.dev testing Currently apply (or to be applied) on farcaster.dev backend label Oct 12, 2022
Copy link
Member

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review and light testing ACK

I like these changes, the displays were kind of insane before.

@h4sh3d h4sh3d merged commit fee16c4 into farcaster-project:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
farcaster.dev testing Currently apply (or to be applied) on farcaster.dev backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants