Farcasterd connect refactor #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCharlatan
force-pushed
the
farcasterdConnectRefactor
branch
from
bef31f0 to
ce0a225
Compare
This is done with the goal of making the processing of make and take offer easier to read by removing most of the and_then statements and unnesting some of the logic. Coincidentally, this also solves a bug where the peer services are not removed from the spawning_services HashSet and where the connect function might double-spawn a connection that has not said Hello to farcasterd yet.
The swap state machine now checks during the transition from SwapdLaunched to SwapdRunning that that the peer connection is up and available before initializing the swap.
After testing some values, 100ms is still ampple time to wait
TheCharlatan
force-pushed
the
farcasterdConnectRefactor
branch
from
5fbde27 to
1b55c6e
Compare
h4sh3d
added
the
farcaster.dev testing
h4sh3d
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
tACK
Over the last week I've encounter only 1 disconnect, on Monday this week, my client took 3 attempts and reconnected successfully to then complete the swap.
EDIT: what I mean by the message below is: never encountered a connection issue with this refactor, all my swaps waited correctly and started after the connection was instantiated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done with the goal of making the processing of make and take offer easier to read by removing most of the and_then statements and unnesting some of the logic.
Coincidentally, this also solves a bug where the peer services are not removed from the spawning_services HashSet and where the connect function might double-spawn a connection that has not said Hello to farcasterd yet.
Lastly, the swap state machine now checks during the transition from SwapdLaunched to SwapdRunning that that the peer connection is up and available before initializing the swap.