Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machines: Add Executor trait #705

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

TheCharlatan
Copy link
Member

@TheCharlatan TheCharlatan commented Aug 30, 2022

Adds an executor trait that is useful for a common operation involving state machines: Creating an event and calling next on the state machine and logging its results.

Based on #693

@TheCharlatan TheCharlatan force-pushed the stateExecutor branch 3 times, most recently from af618ff to 704ae6e Compare September 2, 2022 14:11
@TheCharlatan TheCharlatan marked this pull request as ready for review September 2, 2022 14:12
Adds an executor trait that is useful for a common operation
involving state machines: Creating an event and calling next on the
state machine and logging its results.
@h4sh3d h4sh3d added the farcaster.dev testing Currently apply (or to be applied) on farcaster.dev backend label Oct 12, 2022
Copy link
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Good refactor, the 2 functions were basically the same. Tested the PR is equivalent feature wise.

@h4sh3d h4sh3d merged commit 517c663 into farcaster-project:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
farcaster.dev testing Currently apply (or to be applied) on farcaster.dev backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants