Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow dead code and unused imports #680

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Disallow dead code and unused imports #680

merged 2 commits into from
Aug 24, 2022

Conversation

LeoNero
Copy link
Member

@LeoNero LeoNero commented Aug 23, 2022

No description provided.

@LeoNero LeoNero changed the title Disallow dead code and unused imports [WIP]: disallow dead code and unused imports Aug 23, 2022
@LeoNero LeoNero force-pushed the disallow/dead_code_and_unused_imports branch from 745e6c2 to ff0d823 Compare August 23, 2022 03:16
@TheCharlatan
Copy link
Member

Is this still [WIP]?

@LeoNero LeoNero changed the title [WIP]: disallow dead code and unused imports Disallow dead code and unused imports Aug 23, 2022
@LeoNero
Copy link
Member Author

LeoNero commented Aug 23, 2022

@TheCharlatan not wip anymore, I forgot to update the title before going to bed.

@h4sh3d h4sh3d merged commit 7147e46 into farcaster-project:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkao zkao zkao left review comments

@h4sh3d h4sh3d h4sh3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeoNero @TheCharlatan @h4sh3d @zkao