Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add few comments with some explanations for some decisions #679

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

LeoNero
Copy link
Member

@LeoNero LeoNero commented Aug 23, 2022

No description provided.

@LeoNero LeoNero requested a review from TheCharlatan August 23, 2022 03:12
Cargo.toml Outdated
@@ -84,7 +84,14 @@ paste = "1.0"
prost = "0.10.3"
regex = { version = "1.5", optional = true }
rustc-hex = "2.1.0"
serde_crate = { package = "serde", version = "1", features = ["derive"], optional = true }
# we rename the crate below because there is already a feature called `serde`,
# so it would conflict with the implicity feature that would be added by adding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S/implicity/implicit/?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, don't know where the y came from lol will update it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@LeoNero LeoNero force-pushed the add-simple-comments branch from 37ef02d to 00b0a38 Compare August 23, 2022 16:13
@h4sh3d h4sh3d merged commit e46e6b1 into farcaster-project:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants