Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Bump to core 0.5.1 #655

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Deps: Bump to core 0.5.1 #655

merged 2 commits into from
Aug 15, 2022

Conversation

TheCharlatan
Copy link
Member

No description provided.

@h4sh3d
Copy link
Member

h4sh3d commented Aug 15, 2022

To make tests works see: farcaster-project/farcaster-core#293

We have to create a nightly feature in node that enables farcaster_core/nightly when we compile node with Rust nigthly, i.e. in tests.

[features]
nightly = ["farcaster_core/nightly"]

Unit tests should then pass because of --all-features but we should fix integration tests (test.yml) and other files

cargo test ${{ matrix.test }} --workspace --all-targets --features all,integration_test --color always -- --ignored --test-threads=1

So:

  1. when you done I can push a patch
  2. I patch the CI so we remove code coverage and we get rid of nightly usage

@TheCharlatan
Copy link
Member Author

I am for 2. , the code coverage tool is not practical for our code base and I don't think I ever used it.

@h4sh3d h4sh3d mentioned this pull request Aug 15, 2022
@h4sh3d
Copy link
Member

h4sh3d commented Aug 15, 2022

I am for 2. , the code coverage tool is not practical for our code base and I don't think I ever used it.

Done in #656

Copy link
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just one comment about type used in struct that requires strict encoding.

#[cfg_attr(
feature = "serde",
derive(Serialize, Deserialize),
serde(crate = "serde_crate")
)]
#[display(TookOffer::to_yaml_string)]
pub struct TookOffer {
pub offerid: PublicOfferId,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, as mentioned in farcaster-project/farcaster-core#292, we can use [u8; 16] to avoid manual impl. of encoding. (But with manual From/Into calls in code when we want Uuid types)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TookOffer is printed as a yaml string, so I want to preserve the Uuid type. I am not sure how a impl From would help here.

@TheCharlatan TheCharlatan marked this pull request as ready for review August 15, 2022 13:08
Copy link
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@h4sh3d h4sh3d merged commit 79733e5 into farcaster-project:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants