Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Use bitcoin secret key wherever possible #600

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

TheCharlatan
Copy link
Member

@TheCharlatan TheCharlatan commented Jul 27, 2022

This simplifies the typing and allows us to use proper types instead of raw 32 byte arrays for the Bitcoin secret keys.

@TheCharlatan TheCharlatan force-pushed the bitcoinEncodeSecretKey branch from 819b67f to e6919bb Compare July 27, 2022 12:56
@TheCharlatan TheCharlatan force-pushed the bitcoinEncodeSecretKey branch from e6919bb to c3fd91a Compare July 27, 2022 13:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #600 (c3fd91a) into main (9fabb42) will increase coverage by 0.0%.
The diff coverage is 0.0%.

@@          Coverage Diff          @@
##            main    #600   +/-   ##
=====================================
  Coverage    9.3%    9.3%           
=====================================
  Files         32      32           
  Lines      10621   10616    -5     
=====================================
  Hits         987     987           
+ Misses      9634    9629    -5     
Impacted Files Coverage Δ
src/cli/command.rs 0.0% <0.0%> (ø)
src/databased/runtime.rs 49.2% <0.0%> (+0.3%) ⬆️
src/rpc/request.rs 2.3% <0.0%> (ø)
src/syncerd/bitcoin_syncer.rs 0.0% <0.0%> (ø)
src/syncerd/types.rs 25.0% <0.0%> (ø)
src/walletd/runtime.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fabb42...c3fd91a. Read the comment docs.

@zkao zkao merged commit 69de55f into farcaster-project:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants