Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap: Ensure a checkpoint is only set once and in the correct order #520

Merged
merged 3 commits into from
Jul 3, 2022

Conversation

TheCharlatan
Copy link
Member

This also solves the problem where a checkpoint of the same state would be written to the database again on restore.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022

Codecov Report

Merging #520 (4173830) into main (6122362) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #520     +/-   ##
=======================================
- Coverage   12.1%   12.1%   -0.1%     
=======================================
  Files         34      34             
  Lines      10216   10294     +78     
=======================================
  Hits        1241    1241             
- Misses      8975    9053     +78     
Impacted Files Coverage Δ
src/swapd/runtime.rs 0.0% <0.0%> (ø)
src/swapd/swap_state.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6122362...4173830. Read the comment docs.

src/swapd/swap_state.rs Outdated Show resolved Hide resolved
This also solves the problem where a checkpoint of the same state would
be written to the database again on restore.
Copy link
Member

@zkao zkao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, minor comments related to QA

src/swapd/swap_state.rs Outdated Show resolved Hide resolved
src/swapd/runtime.rs Show resolved Hide resolved
@zkao zkao merged commit 5cdb7a7 into farcaster-project:main Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants