Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap: Allow cancel for alice refundsig before arb lock #518

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

TheCharlatan
Copy link
Member

Alice should be able to cancel the swap up until the point where Bob's lock has confirmed.

@codecov-commenter
Copy link

Codecov Report

Merging #518 (cfff1f5) into main (482985f) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #518     +/-   ##
=======================================
- Coverage   12.4%   12.4%   -0.0%     
=======================================
  Files         34      34             
  Lines       9995   10017     +22     
=======================================
  Hits        1238    1238             
- Misses      8757    8779     +22     
Impacted Files Coverage Δ
src/swapd/runtime.rs 0.0% <0.0%> (ø)
src/swapd/swap_state.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482985f...cfff1f5. Read the comment docs.

@TheCharlatan TheCharlatan added the enhancement New feature or request label Jul 3, 2022
Copy link
Member

@zkao zkao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple, and add btc locked state that was previously missing

@zkao zkao merged commit 47ef31e into farcaster-project:main Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants