Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: Implement sweep address call #517

Merged
merged 5 commits into from
Jul 3, 2022

Conversation

TheCharlatan
Copy link
Member

@TheCharlatan TheCharlatan commented Jul 1, 2022

This can be used to salvage funds from funding addresses in case something goes wrong.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #517 (03e02ad) into main (e690a39) will decrease coverage by 0.2%.
The diff coverage is 1.4%.

@@           Coverage Diff           @@
##            main    #517     +/-   ##
=======================================
- Coverage   12.3%   12.1%   -0.2%     
=======================================
  Files         34      34             
  Lines      10063   10216    +153     
=======================================
+ Hits        1239    1241      +2     
- Misses      8824    8975    +151     
Impacted Files Coverage Δ
src/cli/command.rs 22.2% <0.0%> (-2.7%) ⬇️
src/databased/runtime.rs 40.7% <0.0%> (-0.8%) ⬇️
src/farcasterd/runtime.rs 0.0% <0.0%> (ø)
src/walletd/runtime.rs 0.0% <0.0%> (ø)
src/cli/opts.rs 39.3% <33.3%> (-0.3%) ⬇️
src/swapd/runtime.rs 0.0% <0.0%> (ø)
src/swapd/swap_state.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e690a39...03e02ad. Read the comment docs.

@TheCharlatan TheCharlatan linked an issue Jul 2, 2022 that may be closed by this pull request
@TheCharlatan TheCharlatan marked this pull request as ready for review July 2, 2022 08:47
This can be used to salvage funds from funding addresses in case
something goes wrong.
Copy link
Member

@zkao zkao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good PR, minor comments only

src/cli/command.rs Outdated Show resolved Hide resolved
src/farcasterd/runtime.rs Outdated Show resolved Hide resolved
src/farcasterd/runtime.rs Outdated Show resolved Hide resolved
@zkao zkao merged commit 6122362 into farcaster-project:main Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Funding Recovery
3 participants