Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: Add endpoint to print information about a passed-in offer #496

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

TheCharlatan
Copy link
Member

This completes #457 by adding an endpoint to display information about an offer. It is similar to the take command but does not interact with any of the other microservices.

@codecov-commenter
Copy link

Codecov Report

Merging #496 (d57e357) into main (9f46ef8) will increase coverage by 0.0%.
The diff coverage is 6.7%.

@@          Coverage Diff          @@
##            main    #496   +/-   ##
=====================================
  Coverage   12.0%   12.0%           
=====================================
  Files         29      30    +1     
  Lines       8515    8522    +7     
=====================================
+ Hits        1022    1023    +1     
- Misses      7493    7499    +6     
Impacted Files Coverage Δ
src/cli/command.rs 27.0% <0.0%> (-0.6%) ⬇️
src/cli/opts.rs 45.3% <25.0%> (-0.8%) ⬇️
src/swapd/runtime.rs 0.0% <0.0%> (ø)
src/swapd/syncer_client.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f46ef8...d57e357. Read the comment docs.

Copy link
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@h4sh3d h4sh3d merged commit 6ca6aee into farcaster-project:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve OfferId / serialized Offer / Offer details information interplay
4 participants