Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farcasterd: Check if peerd listen launched successfully #484

Merged

Conversation

TheCharlatan
Copy link
Member

Uses the same heuristic as the connect_peer method.

@TheCharlatan TheCharlatan linked an issue Jun 8, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #484 (6fddd08) into main (d2f498b) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #484     +/-   ##
=======================================
- Coverage   12.0%   12.0%   -0.0%     
=======================================
  Files         29      29             
  Lines       8483    8484      +1     
=======================================
- Hits        1021    1019      -2     
- Misses      7462    7465      +3     
Impacted Files Coverage Δ
src/farcasterd/runtime.rs 0.0% <0.0%> (ø)
src/service.rs 11.5% <ø> (ø)
src/opts.rs 78.9% <0.0%> (-1.1%) ⬇️
src/rpc/request.rs 14.8% <0.0%> (-0.1%) ⬇️
src/config.rs 0.0% <0.0%> (ø)
src/peerd/runtime.rs 0.0% <0.0%> (ø)
src/swapd/runtime.rs 0.0% <0.0%> (ø)
src/syncerd/monero_syncer.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f498b...6fddd08. Read the comment docs.

Copy link
Member

@h4sh3d h4sh3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK with added changes. Fix when peerd was registered in listens before crash.

Please @TheCharlatan give a 👍 if you agree we my changes, after that we can merge.

Copy link
Member Author

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on your changes.

@h4sh3d h4sh3d merged commit 9f46ef8 into farcaster-project:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error returned when an offer binds to an already in use address
3 participants