Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peerd: Only send whitelisted Msg's over the bridge #475

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

TheCharlatan
Copy link
Member

Only some of the messages should be allowed through the PeerdReceiverRuntime to the peerd Runtime. I don't like this explicit listing of messages, is there some other method to select this subset of enum variants?

@codecov-commenter
Copy link

Codecov Report

Merging #475 (7a330e7) into main (c9038d2) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #475     +/-   ##
=======================================
- Coverage   12.1%   12.1%   -0.0%     
=======================================
  Files         29      29             
  Lines       8437    8440      +3     
=======================================
  Hits        1019    1019             
- Misses      7418    7421      +3     
Impacted Files Coverage Δ
src/peerd/runtime.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9038d2...7a330e7. Read the comment docs.

@TheCharlatan TheCharlatan linked an issue Jun 7, 2022 that may be closed by this pull request
@TheCharlatan TheCharlatan marked this pull request as ready for review June 7, 2022 17:51
@h4sh3d
Copy link
Member

h4sh3d commented Jun 8, 2022

There is the matches! macro in std but I'm not sure it's going to improve the code. I'm fine with the current patch

@TheCharlatan
Copy link
Member Author

There is the matches! macro in std but I'm not sure it's going to improve the code. I'm fine with the current patch

I like this better, and pushed a patch.

@h4sh3d h4sh3d merged commit 64c869f into farcaster-project:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate peerd command firewalling
3 participants