Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract from swapd runtime State #446

Merged
merged 4 commits into from
Jun 21, 2022

Conversation

zkao
Copy link
Member

@zkao zkao commented May 25, 2022

No description provided.

@zkao zkao changed the title extract Swapd runtime state extract from swapd runtime State May 25, 2022
@zkao zkao force-pushed the swapd-runtime-state branch from 1c33ece to fcab350 Compare June 17, 2022 11:52
@zkao zkao marked this pull request as ready for review June 17, 2022 11:53
Copy link
Member

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK once rebased.

@zkao zkao force-pushed the swapd-runtime-state branch from fcab350 to 516df0e Compare June 21, 2022 11:47
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #446 (e9f6946) into main (f5fd275) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #446     +/-   ##
=======================================
- Coverage   12.0%   12.0%   -0.0%     
=======================================
  Files         31      32      +1     
  Lines       8515    8518      +3     
=======================================
  Hits        1022    1022             
- Misses      7493    7496      +3     
Impacted Files Coverage Δ
src/swapd/runtime.rs 0.0% <0.0%> (ø)
src/swapd/swap_state.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5fd275...e9f6946. Read the comment docs.

@zkao zkao force-pushed the swapd-runtime-state branch from f60129e to e9f6946 Compare June 21, 2022 14:53
@TheCharlatan TheCharlatan linked an issue Jun 21, 2022 that may be closed by this pull request
Copy link
Member

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@@ -1751,7 +1325,7 @@ impl Runtime {
if self.state.a_refundsig()
&& !self.state.a_xmr_locked()
&& !self.state.a_buy_published()
&& self.state.remote_params().is_some()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@TheCharlatan TheCharlatan merged commit 1126b4c into farcaster-project:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swapd: Handle error from remote_params_candidate
3 participants