-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make progress serializable #438
Make progress serializable #438
Conversation
Codecov Report
@@ Coverage Diff @@
## main #438 +/- ##
=======================================
- Coverage 13.1% 12.9% -0.2%
=======================================
Files 27 27
Lines 7843 7893 +50
=======================================
- Hits 1028 1019 -9
- Misses 6815 6874 +59
Continue to review full report at Codecov.
|
c539ce1
to
9b72794
Compare
9b72794
to
4b0b861
Compare
4b0b861
to
88d318e
Compare
I want to propose an alternative approach that doesn't change the idea of progress being a stream of info. What I want to try should look like:
The idea is also to keep the correct order of events sent to progress |
Cosing in support of #479 |
Make the
progress
cli call serializable. Closes #285 . Based on #437 .progress
on current main:progress
after this PR: