Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close and delete wallet after sweep #418

Conversation

TheCharlatan
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #418 (2706deb) into main (1dec4d8) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #418     +/-   ##
=======================================
- Coverage   13.2%   13.1%   -0.1%     
=======================================
  Files         27      27             
  Lines       7801    7837     +36     
=======================================
  Hits        1028    1028             
- Misses      6773    6809     +36     
Impacted Files Coverage Δ
src/config.rs 0.0% <0.0%> (ø)
src/farcasterd/runtime.rs 0.0% <0.0%> (ø)
src/syncerd/monero_syncer.rs 0.0% <0.0%> (ø)
src/syncerd/opts.rs 2.7% <0.0%> (-0.2%) ⬇️
src/lib.rs 11.2% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dec4d8...2706deb. Read the comment docs.

@TheCharlatan TheCharlatan force-pushed the closeAndDeleteWalletAfterSweep branch 2 times, most recently from 8932e93 to 3c529e6 Compare April 16, 2022 16:50
@TheCharlatan TheCharlatan force-pushed the closeAndDeleteWalletAfterSweep branch from 3c529e6 to 6e5ad85 Compare April 16, 2022 16:52
@TheCharlatan TheCharlatan changed the title Close and delete wallet after sweep Close wallet after sweep Apr 16, 2022
@TheCharlatan TheCharlatan changed the title Close wallet after sweep Close and delete wallet after sweep Apr 25, 2022
@TheCharlatan TheCharlatan marked this pull request as draft April 25, 2022 10:56
@TheCharlatan
Copy link
Member Author

Still requires testing.

@TheCharlatan TheCharlatan force-pushed the closeAndDeleteWalletAfterSweep branch 2 times, most recently from ff078c5 to 45fb905 Compare April 26, 2022 13:29
@TheCharlatan
Copy link
Member Author

Tested.

@TheCharlatan TheCharlatan marked this pull request as ready for review April 26, 2022 13:31
@TheCharlatan TheCharlatan force-pushed the closeAndDeleteWalletAfterSweep branch from 45fb905 to 2762bef Compare April 27, 2022 07:46
@Lederstrumpf Lederstrumpf merged commit 358027e into farcaster-project:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants