Skip to content

Commit

Permalink
remove baseModel
Browse files Browse the repository at this point in the history
  • Loading branch information
fan123199 committed Jul 31, 2018
1 parent a7b5d10 commit 140eb2a
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 40 deletions.
3 changes: 2 additions & 1 deletion app/src/main/java/im/fdx/v2ex/MyApp.kt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import androidx.core.content.edit
import com.elvishew.xlog.LogLevel
import com.elvishew.xlog.XLog
import im.fdx.v2ex.utils.Keys
import im.fdx.v2ex.utils.extensions.logd

val pref: SharedPreferences by lazy {
MyApp.get().mPrefs
Expand Down Expand Up @@ -56,6 +57,6 @@ class MyApp : Application() {
else -> LogLevel.NONE
})
isLogin = mPrefs.getBoolean(Keys.PREF_KEY_IS_LOGIN, false)
XLog.tag("MyApp").d("onCreate\nisLogin:$isLogin")
logd("onCreate\nisLogin:$isLogin")
}
}
9 changes: 0 additions & 9 deletions app/src/main/java/im/fdx/v2ex/model/BaseModel.kt

This file was deleted.

2 changes: 1 addition & 1 deletion app/src/main/java/im/fdx/v2ex/model/NotificationModel.kt
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ class NotificationModel(var time: String? = "",
var topic: Topic? = Topic(),
var member: Member? = Member(),
var content: String? = "",
var id: String? = "") : BaseModel(), Parcelable {
var id: String? = "") : Parcelable {
}
2 changes: 1 addition & 1 deletion app/src/main/java/im/fdx/v2ex/ui/BaseActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ abstract class BaseActivity : AppCompatActivity() {

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
var textSizeMode = defaultSharedPreferences.getString("pref_text_size", "0").toInt()
val textSizeMode = defaultSharedPreferences.getString("pref_text_size", "0").toInt()
MyApp.get().curTextSize = textSizeMode
when (textSizeMode) {
MODE_SMALL -> {
Expand Down
1 change: 0 additions & 1 deletion app/src/main/java/im/fdx/v2ex/ui/details/DetailsAdapter.kt
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ import java.io.IOException
/**
* Created by fdx on 15-9-7.
* 详情页的Adapter。
* todo 把 allList 分离
*/
class DetailsAdapter(private val mContext: Context,
private val callback: DetailsAdapter.AdapterCallback
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/java/im/fdx/v2ex/ui/details/Reply.kt
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package im.fdx.v2ex.ui.details

import android.os.Parcelable
import im.fdx.v2ex.model.BaseModel
import im.fdx.v2ex.ui.member.Member
import kotlinx.android.parcel.Parcelize

Expand Down Expand Up @@ -37,7 +36,7 @@ data class Reply(var id: String = "",
var isThanked: Boolean = false,
var member: Member? = null,
var isLouzu: Boolean = false
) : BaseModel(), Parcelable {
) : Parcelable {

override fun toString() = "Reply{content='$content_rendered}"
}
21 changes: 4 additions & 17 deletions app/src/main/java/im/fdx/v2ex/ui/main/MyDiffCallback.kt
Original file line number Diff line number Diff line change
@@ -1,39 +1,26 @@
package im.fdx.v2ex.ui.main

import android.support.v7.util.DiffUtil
import im.fdx.v2ex.model.BaseModel
import im.fdx.v2ex.ui.details.Reply

/**
* Created by fdx on 2017/7/11.
* fdx will maintain it
*/
class MyDiffCallback(private val oldList: List<BaseModel>, private val newList: List<BaseModel>) : DiffUtil.Callback() {
class MyDiffCallback(private val oldList: List<Topic>, private val newList: List<Topic>) : DiffUtil.Callback() {

override fun areItemsTheSame(oldItemPosition: Int, newItemPosition: Int): Boolean {

if (oldList[oldItemPosition] is Topic && newList[newItemPosition] is Topic) {
return (oldList[oldItemPosition] as Topic).id == (newList[newItemPosition] as Topic).id
} else if (oldList[oldItemPosition] is Reply && newList[newItemPosition] is Reply)
return (oldList[oldItemPosition] as Reply).id == (newList[newItemPosition] as Reply).id
else return false
return oldList[oldItemPosition].id == newList[newItemPosition].id
}

override fun getOldListSize() = oldList.size
override fun getNewListSize() = newList.size


/**
* 有点问题,GoodText不加载图片
*/
override fun areContentsTheSame(oldItemPosition: Int, newItemPosition: Int): Boolean {
if (oldList[oldItemPosition] is Topic && newList[newItemPosition] is Topic) {
return (oldList[oldItemPosition] as Topic).replies == (newList[newItemPosition] as Topic).replies &&
(oldList[oldItemPosition] as Topic).content_rendered == (newList[newItemPosition] as Topic).content_rendered
} else if (oldList[oldItemPosition] is Reply && newList[newItemPosition] is Reply)
return (oldList[oldItemPosition] as Reply).thanks == (newList[newItemPosition] as Reply).thanks &&
(oldList[oldItemPosition] as Reply).isThanked == (newList[newItemPosition] as Reply).isThanked
else return false
return oldList[oldItemPosition].replies == newList[newItemPosition].replies &&
oldList[oldItemPosition].content_rendered == newList[newItemPosition].content_rendered
}

override fun getChangePayload(oldItemPosition: Int, newItemPosition: Int): Any? {
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/java/im/fdx/v2ex/ui/main/Topic.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package im.fdx.v2ex.ui.main

import android.arch.persistence.room.*
import android.os.Parcelable
import im.fdx.v2ex.model.BaseModel
import im.fdx.v2ex.ui.member.Member
import im.fdx.v2ex.ui.node.Node
import kotlinx.android.parcel.Parcelize
Expand Down Expand Up @@ -67,7 +66,7 @@ class Topic(
var last_modified: Long = 0,
var last_touched: Long = 0,
@Ignore
var comments: MutableList<Comment> = mutableListOf()) : BaseModel(), Parcelable {
var comments: MutableList<Comment> = mutableListOf()) : Parcelable {

override fun toString() = "标题:$title,\n内容:$content"

Expand Down
3 changes: 1 addition & 2 deletions app/src/main/java/im/fdx/v2ex/ui/member/Member.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package im.fdx.v2ex.ui.member

import android.arch.persistence.room.ColumnInfo
import android.os.Parcelable
import im.fdx.v2ex.model.BaseModel
import kotlinx.android.parcel.Parcelize

/**
Expand Down Expand Up @@ -50,7 +49,7 @@ data class Member(
var location: String? = "",
var twitter: String? = "",
var website: String? = ""
) : BaseModel(), Parcelable {
) : Parcelable {

val avatarNormalUrl: String
get() = "http:" + avatar_normal
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/java/im/fdx/v2ex/ui/member/MemberReplyModel.kt
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package im.fdx.v2ex.ui.member

import android.os.Parcelable
import im.fdx.v2ex.model.BaseModel
import im.fdx.v2ex.ui.main.Topic
import kotlinx.android.parcel.Parcelize

Expand All @@ -13,4 +12,4 @@ import kotlinx.android.parcel.Parcelize
data class MemberReplyModel(var id: String? = "",
var topic: Topic = Topic(),
var content: String? = null,
var create: Long = 0L) : BaseModel(), Parcelable
var create: Long = 0L) : Parcelable
3 changes: 1 addition & 2 deletions app/src/main/java/im/fdx/v2ex/ui/node/Node.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package im.fdx.v2ex.ui.node

import android.arch.persistence.room.ColumnInfo
import android.os.Parcelable
import im.fdx.v2ex.model.BaseModel
import kotlinx.android.parcel.Parcelize

/**
Expand Down Expand Up @@ -61,7 +60,7 @@ data class Node(
@ColumnInfo(name = "node_avatar_large")

var avatar_large: String = "",
var header: String = "") : BaseModel(), Parcelable {
var header: String = "") : Parcelable {

val avatarMiniUrl: String
get() = "http:$avatar_mini"
Expand Down

0 comments on commit 140eb2a

Please sign in to comment.