fix: also lazy load members for archive #1917
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should speed up loading the archived rooms. One of the reasons it was so slow, is because we were loading all room members! Additionally this may work around a bug in Synapse, where rooms stuck in their partial state may block sync indefinitely. Relates to famedly/product-management#2250
nico-famedly
force-pushed
the
nico/fix-archive-load
branch
from
2cbed74
to
b839273
Compare
mErrenst
approved these changes
Sep 17, 2024
|
Oh, was already merged XD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed up loading the archived rooms. One of the reasons it was so slow, is because we were loading all room members!
Additionally this may work around a bug in Synapse, where rooms stuck in their partial state may block sync indefinitely.
Relates to https://github.com/famedly/product-management/issues/2250