Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipad layout for header #661

Merged
merged 1 commit into from
Jan 26, 2025
Merged

ipad layout for header #661

merged 1 commit into from
Jan 26, 2025

Conversation

wbazant
Copy link
Collaborator

@wbazant wbazant commented Jan 13, 2025

Closes #595

Copy link
Collaborator

@ezwelty ezwelty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbazant Elegant solution which seems to do the trick!

Not something I suggest we tackle now, but I'll note that this sort of layout optimization gets harder with additional languages and unanticipated languages injected by browser translation tools (i.e. with a wider range of string length and text direction in a given design element) and so it can be good to think about making the existing layout(s) more robust (e.g. prevent the dropdown arrow from wrapping below the button or drop the arrow entirely, allow the top bar to grow wider for overflow, ...).

@ezwelty ezwelty merged commit 8be4d1f into falling-fruit:main Jan 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout of top ribbon for small desktop heights can overflow
2 participants